mirror of
https://github.com/ThearchyHelios/AgentLab.git
synced 2026-11-19 10:21:58 +00:00
审批质询收尾:工件页签认得质询回答;几处问答串要对的审批不同、审批列表取不到时各自照样列出
- 工件名:质询的回答文档以 inquiry_answer 登记在运行名下,工件页签原先直接显示英文原值。ARTIFACT_KIND_LABEL 加「质询 回答」,说明在 meta.question 有值时写「质询「…」的回答」(服务端只记前 40 字,满 40 字的补省略号),没有时写「审批 质询的回答:逐段的片段和每个数字的出处」;文案放在 INQUIRY_TEXT - 问答串的竞态:loadApprovalDocs 发现别处正在取审批列表就直接返回,没把这一处要对的审批记进 asked。请求回来后这一处的 unknown 不变、effect 不再执行,settled 一直为假,头上写着「· N 次」,别的审批里问的那几条一直不显示(一张卡审两份 报告;运行详情的待审批卡和证据页签同时挂着、审批列表失败时)。现在提前返回前也把这一处的 id 并进 asked:列表按运行取, 在路上的那一份本来就带着全部审批,不另发请求 - 预览用例:inquiry-approval-two(一张卡审两份报告)、inquiry-run-waiting(待审批卡和证据页签同时挂着)、 inquiry-run-artifacts(工件页签);夹具补探索运行的工件列表 run_artifacts - check-inquiry:审批列表压住、再答 404,两处的条目都列出(查不到审批的单独成组),头上的次数和列出的条数一致、审批 列表只取一次;工件页签里有「质询回答」的名字和说明、不出现英文的种类名、打开的弹窗标题也是中文;390px 深浅色下不溢出、 看得清
This commit is contained in:
@@ -1,5 +1,5 @@
|
||||
{
|
||||
"//": "审批质询预览用例与 check-inquiry 共用的夹具(frontend/src/dev/fixtures/inquiry.tsx)。报告文档和回答文档由后端 evidence.build_catalog + compose_doc 真实组装(虚构的超市、片区、金额),查询快照照质询工件接口的样子给:遮罩列的值写「已遮罩」,另带 masked。生成脚本不在仓库里:改了文档的形状,照这个思路按后端的输出重新生成",
|
||||
"//": "审批质询预览用例与 check-inquiry 共用的夹具(frontend/src/dev/fixtures/inquiry.tsx)。报告文档和回答文档由后端 evidence.build_catalog + compose_doc 真实组装(虚构的超市、片区、金额),查询快照照质询工件接口的样子给:遮罩列的值写「已遮罩」,另带 masked。生成脚本不在仓库里:改了文档的形状,照这个思路按后端的输出重新生成。run_artifacts 是探索运行的工件列表(照 GET /api/runs/{id}/artifacts 的样子手写,质询回答的 meta 同 engine/inquiry.py 写的 {report, unit, question: 问题的前 40 字}),给运行详情「工件」页签的用例",
|
||||
"runs": {
|
||||
"approve": "run-inq-approve",
|
||||
"formal": "run-inq-formal",
|
||||
@@ -4278,5 +4278,58 @@
|
||||
"masked": []
|
||||
}
|
||||
},
|
||||
"run_artifacts": [
|
||||
{
|
||||
"id": "8cb677489bbaafcafd3b0f0df1939c1ca57cccaa3c065e14c4efe2991a3dd9a9",
|
||||
"kind": "report_doc",
|
||||
"node_id": "write",
|
||||
"size": 18234,
|
||||
"meta": {},
|
||||
"created_at": "2026-10-05T06:30:00"
|
||||
},
|
||||
{
|
||||
"id": "02ca8aeabca59d785d982b321d22ff889cb2da5a037cd4a080407e9044356434",
|
||||
"kind": "query_snapshot",
|
||||
"node_id": null,
|
||||
"size": 1460,
|
||||
"meta": {},
|
||||
"created_at": "2026-10-05T06:44:30"
|
||||
},
|
||||
{
|
||||
"id": "911780ed990217a2a2e7e3424a9408d23b53a524ba5d1812ec677b7d6b5b80aa",
|
||||
"kind": "inquiry_answer",
|
||||
"node_id": null,
|
||||
"size": 2140,
|
||||
"meta": {
|
||||
"report": "write",
|
||||
"unit": "u2",
|
||||
"question": "退款率怎么算的?"
|
||||
},
|
||||
"created_at": "2026-10-05T06:45:00"
|
||||
},
|
||||
{
|
||||
"id": "4ed3d62d2af13bbea40195283f3caf63462ca76bb5d4f7ddf1216d36dd5e0463",
|
||||
"kind": "inquiry_answer",
|
||||
"node_id": null,
|
||||
"size": 2510,
|
||||
"meta": {
|
||||
"report": "write",
|
||||
"unit": null,
|
||||
"question": "枫岭区的销售额是否包含线上订单?如果包含,线上订单按下单门店还是按收货地址归到片"
|
||||
},
|
||||
"created_at": "2026-10-05T06:52:00"
|
||||
},
|
||||
{
|
||||
"id": "1c66d590eac155dec35e2215e20c6e7497e96d0b2d73894eff1dea3fb641bb51",
|
||||
"kind": "inquiry_answer",
|
||||
"node_id": null,
|
||||
"size": 1980,
|
||||
"meta": {
|
||||
"report": "write",
|
||||
"unit": "u2"
|
||||
},
|
||||
"created_at": "2026-10-05T06:58:00"
|
||||
}
|
||||
],
|
||||
"card_artifact": "757e03414694c3b3480236718d32082ba449e7712d9ce99f4aee39ffdc5c3f4e"
|
||||
}
|
||||
|
||||
@@ -1,7 +1,9 @@
|
||||
import { useState, type JSX } from 'react'
|
||||
import { useMemo, useState, type JSX } from 'react'
|
||||
import { createPortal } from 'react-dom'
|
||||
import { ArtifactsPane, useRunArtifacts } from '../../pages/runs/ArtifactsPane'
|
||||
import { EvidencePane } from '../../pages/runs/EvidencePane'
|
||||
import { ApprovalCard } from '../../run/RunPanel'
|
||||
import { emptyTrace } from '../../run/trace'
|
||||
import type { Approval, ApprovalReport, Run } from '../../types'
|
||||
import fx from './inquiry.json'
|
||||
|
||||
@@ -20,12 +22,17 @@ import fx from './inquiry.json'
|
||||
* React 树里排在前面)和右栏;「收起浮层」按钮开关浮层
|
||||
* - ?syn=inquiry-approval-steps:同一份报告先后两张审批(主管审批 → 总监审批),「处理掉这张」换下一张;卡按审批 id
|
||||
* 重新挂(同右栏)。?syn=inquiry-approval-steps-same:同一个卡片实例换审批(同画布的审批浮层,不按 id 重新挂)
|
||||
* - ?syn=inquiry-approval-two:一张卡审两份报告(写月报、写周报),两份报告的问答串各自挂着、共用这次运行的审批列表
|
||||
*
|
||||
* 运行详情的「证据」页签(pages/runs/EvidencePane,是否可问由它按运行状态判断):
|
||||
* - ?syn=inquiry-run-explore:封存了的探索运行,报告上给入口,问答追加在封存之后
|
||||
* - ?syn=inquiry-run-formal:封存了的正式运行,不给入口,审批时问过的照列
|
||||
* - ?syn=inquiry-run-waiting:停在审批上的运行,同运行详情直接打开「证据」页签:时间线里的待审批卡和证据页签同时挂着
|
||||
* 同一份报告的问答串(卡上这张审批里问的直接认,证据页签哪张审批都要对一下)
|
||||
* - ?syn=inquiry-run-artifacts:运行详情的「工件」页签(pages/runs/ArtifactsPane),工件列表里有质询的回答
|
||||
*
|
||||
* 列表、提问、质询工件、报告文档、证据图、审批列表、设置都由检查脚本用 page.route 伪造;直接打开时问答串照实说无法读取。
|
||||
* 列表、提问、质询工件、报告文档、证据图、审批列表、工件列表、设置都由检查脚本用 page.route 伪造;直接打开时问答串照实说
|
||||
* 无法读取。
|
||||
*/
|
||||
|
||||
const RUNS = fx.runs
|
||||
@@ -115,6 +122,36 @@ function RunEvidence({ run, name }: { run: Run; name: string }) {
|
||||
)
|
||||
}
|
||||
|
||||
/**
|
||||
* 停在审批上的运行,同运行详情直接打开「证据」页签:时间线(一直挂着)里的待审批卡在上,证据页签在下,两处挂着同一份
|
||||
* 报告的问答串。卡上的问答串认得这张审批,证据页签不认任何审批(cardId 为空),两处要为不同的几张审批取审批列表
|
||||
*/
|
||||
function Waiting({ approval, run }: { approval: Approval; run: Run }) {
|
||||
return (
|
||||
<div className="flex min-h-screen min-w-0 flex-col" data-fixture="inquiry-run-waiting">
|
||||
<div className="mx-auto w-full max-w-3xl p-4" data-fixture-card="">
|
||||
<div className="overflow-hidden rounded-lg border" style={{ borderColor: 'var(--warn)' }}>
|
||||
<ApprovalCard approval={approval} onResolved={() => undefined} showWorkflow={false} />
|
||||
</div>
|
||||
</div>
|
||||
<div className="h-[80vh] min-w-0 border-t" data-fixture-evidence="">
|
||||
<EvidencePane run={run} output={null} labelOf={(id) => (id ? LABELS[id] : undefined)} refreshKey="0" />
|
||||
</div>
|
||||
</div>
|
||||
)
|
||||
}
|
||||
|
||||
/** 运行详情的「工件」页签:工件列表由检查脚本按 inquiry.json 的 run_artifacts 答 */
|
||||
function RunArtifacts({ run }: { run: Run }) {
|
||||
const list = useRunArtifacts(run.id, '0')
|
||||
const trace = useMemo(() => emptyTrace(), [])
|
||||
return (
|
||||
<div className="h-screen min-w-0" data-fixture="inquiry-run-artifacts">
|
||||
<ArtifactsPane list={list} graph={null} trace={trace} labelOf={(id) => (id ? LABELS[id] : undefined)} />
|
||||
</div>
|
||||
)
|
||||
}
|
||||
|
||||
export const cases: Record<string, () => JSX.Element> = {
|
||||
'inquiry-approval': () => (
|
||||
<Card name="inquiry-approval" approval={approvalOf(fx.approval_id, RUNS.approve, 'exploratory', reports.approve)} />
|
||||
@@ -138,6 +175,18 @@ export const cases: Record<string, () => JSX.Element> = {
|
||||
),
|
||||
'inquiry-approval-steps': () => <Steps name="inquiry-approval-steps" keyed />,
|
||||
'inquiry-approval-steps-same': () => <Steps name="inquiry-approval-steps-same" keyed={false} />,
|
||||
'inquiry-approval-two': () => (
|
||||
<Card name="inquiry-approval-two" approval={{
|
||||
...approvalOf(fx.approval_id, RUNS.approve, 'exploratory', reports.approve),
|
||||
payload: { kind: 'human_node', message: '请审核 9 月月报和第 39 周周报。',
|
||||
reports: [reports.approve, { ...reports.approve, node_id: 'write2', label: '写周报' }] },
|
||||
}} />
|
||||
),
|
||||
'inquiry-run-explore': () => <RunEvidence name="inquiry-run-explore" run={runOf(RUNS.explore, 'exploratory')} />,
|
||||
'inquiry-run-formal': () => <RunEvidence name="inquiry-run-formal" run={runOf(RUNS.sealed, 'formal')} />,
|
||||
'inquiry-run-waiting': () => (
|
||||
<Waiting approval={approvalOf(fx.approval_id, RUNS.approve, 'exploratory', reports.approve)}
|
||||
run={{ ...runOf(RUNS.approve, 'exploratory'), status: 'interrupted', manifest_hash: null, manifest_seq: null, finished_at: null }} />
|
||||
),
|
||||
'inquiry-run-artifacts': () => <RunArtifacts run={runOf(RUNS.explore, 'exploratory')} />,
|
||||
}
|
||||
|
||||
@@ -3500,6 +3500,19 @@ export const INQUIRY_TEXT = {
|
||||
snapshotLoading: '正在读取查询结果…',
|
||||
snapshotFailed: '无法读取这次查询的结果',
|
||||
masked: (columns: string) => `${columns} 在数据源中设置了遮罩,不显示原值`,
|
||||
|
||||
// ---- 运行详情「工件」页签:回答文档按工件种类 inquiry_answer 记在运行名下(pages/runs/model.ts 的工件名和说明) ----
|
||||
artifactKind: '质询回答',
|
||||
/**
|
||||
* 服务端在工件的 meta 里只记问题的前 40 字(engine/inquiry.py 的 QUESTION_BRIEF):满 40 字的多半截断过,末尾补省略号,
|
||||
* 免得半句话读成整个问题
|
||||
*/
|
||||
artifactAbout: (question: string) => {
|
||||
const chars = [...question.trim()]
|
||||
return `质询「${chars.join('')}${chars.length >= 40 ? '…' : ''}」的回答`
|
||||
},
|
||||
/** 没记问题摘要的(这一版之前存的):照报告文档的说法写装的是什么 */
|
||||
artifactAboutNone: '审批质询的回答:逐段的片段和每个数字的出处',
|
||||
}
|
||||
|
||||
/**
|
||||
|
||||
@@ -10,6 +10,7 @@ import {
|
||||
RUN_STATUS_ORDER, STATUS, resolveStatus, serverStatusOf, type StatusCode,
|
||||
} from '../../lib/status'
|
||||
import { formatSpan, parseServerTime } from '../../lib/format'
|
||||
import { INQUIRY_TEXT } from '../../lib/terms'
|
||||
import { hasPendingApproval } from '../../store/catalog'
|
||||
|
||||
// -------------------------------------------------------------------------
|
||||
@@ -334,6 +335,7 @@ export const ARTIFACT_KIND_LABEL: Record<string, string> = {
|
||||
schema_snapshot: '表结构快照',
|
||||
dual_check: '双盲复算对照',
|
||||
challenge: '反方审稿记录',
|
||||
inquiry_answer: INQUIRY_TEXT.artifactKind,
|
||||
}
|
||||
export const artifactKindLabel = (kind: string): string => ARTIFACT_KIND_LABEL[kind] ?? kind
|
||||
|
||||
@@ -356,6 +358,9 @@ export function artifactDescription(kind: string, meta?: Record<string, any> | n
|
||||
? `双盲复算:${meta.metrics} 个指标两边的 SQL、取值与差异说明` : '双盲复算:两边的 SQL、取值与差异说明'
|
||||
// 反方审稿的完整记录(工件行的 meta 里有 {report: 审的报告节点})
|
||||
case 'challenge': return '反方审稿:每句结论的判断、理由和反方执行的查询'
|
||||
// 审批质询的回答文档(工件行的 meta 里有 {report, unit, question: 问题的前 40 字}):不挂在节点上,靠问题认出是哪一条
|
||||
case 'inquiry_answer': return typeof meta?.question === 'string' && meta.question.trim()
|
||||
? INQUIRY_TEXT.artifactAbout(meta.question) : INQUIRY_TEXT.artifactAboutNone
|
||||
default: return '工件'
|
||||
}
|
||||
}
|
||||
|
||||
@@ -308,7 +308,17 @@ export const useInquiry = create<InquiryState>((set, get) => ({
|
||||
},
|
||||
|
||||
loadApprovalDocs: async (runId, ids) => {
|
||||
if (get().approvalDocs[runId]?.status === 'loading') return
|
||||
const inflight = get().approvalDocs[runId]
|
||||
if (inflight?.status === 'loading') {
|
||||
// 别处已经在取(同一张卡审两份报告;运行详情的待审批卡和证据页签同时挂着,两处要对的审批不同):不再另取,但这一处
|
||||
// 要对的也记成取过——列表按运行取、不按审批,在路上的那一份本来就带着全部审批。只是提前返回的话,这一处的 unknown
|
||||
// 在请求回来之后不变、effect 不再执行,settled 一直为假:头上写着「· N 次」,别的审批里问的那几条一直不显示
|
||||
const asked = [...new Set([...inflight.asked, ...ids])]
|
||||
if (asked.length > inflight.asked.length) {
|
||||
set((s) => ({ approvalDocs: { ...s.approvalDocs, [runId]: { ...s.approvalDocs[runId]!, asked } } }))
|
||||
}
|
||||
return
|
||||
}
|
||||
set((s) => {
|
||||
const cur = s.approvalDocs[runId]
|
||||
return { approvalDocs: { ...s.approvalDocs, [runId]: {
|
||||
|
||||
Reference in New Issue
Block a user