mirror of
https://github.com/ThearchyHelios/AgentLab.git
synced 2026-11-20 09:42:03 +00:00
ec5d9398b5
为什么:这四处的 signed_by.verified / signed_by_verified 写死 False。开了登录时署名就是登录的人,封存证据里却记着 「未认证」,和审计表、待办派单、run.origin 的 verified 口径对不上——留痕记错了事实(05-已知遗留 (c))。 做了什么:api/deps 新增 signer_verified()(开了登录、这次请求的身份认证过时为真;关登录、不在请求里为假),和 signer_of 配对。表格导入提交、按期移除 / 作废接受、清除原件三个写接口在请求那一刻算好,和 signed_by 一起往下传到 recipe_imports._manifest、source_versions.manifest_doc / _revoked_record、table_versions.purge_import_raw;没有署名的 (退回暂存区上记的那个)照实记未认证。新参数都带默认值 False:运行里按配方导入一期(files/imports.py,署名取动作确认人 或发起人)没有请求身份,照旧记未认证。已封存的旧清单不改写,读取复验照旧。 测试:test_signer_verified(signer_verified 跟请求身份走;作废记录照给的写;开登录首次导入的清单 verified=True、清除原件 记录 signed_by 是登录的人且 verified=True,请求体里填的名字不看)。关登录的老断言(False)照旧通过。
64 lines
2.9 KiB
Python
64 lines
2.9 KiB
Python
"""导入清单、累积快照清单、作废记录、清除原件记录如实写「是否认证」(docs/design/next-round/05-已知遗留.md (c))。
|
|
|
|
以前四处都写死 False:开了登录、署名就是登录的人,封存的证据里却记着「未认证」,和审计表、待办派单、run.origin 的
|
|
verified 对不上。现在由 api/deps.signer_verified 在请求那一刻定下、和署名一起往下传:开登录为真,关登录(自报的署名)
|
|
为假。已封存的旧清单不改写(关登录时的形状见 test_table_imports_api、test_source_versions_api、test_datasources_upload)。
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
from app.api import deps
|
|
from app.core import artifact_store
|
|
from app.db.models import TableImport
|
|
from tests.fakes import auth_env
|
|
from tests.test_table_imports_api import first_import, get, store, unique # noqa: F401 - store 是 autouse 夹具
|
|
|
|
|
|
@pytest.fixture
|
|
async def admin():
|
|
await auth_env.reset()
|
|
c = await auth_env.turn_on_local("root")
|
|
try:
|
|
yield c
|
|
finally:
|
|
await c.aclose()
|
|
await auth_env.reset()
|
|
|
|
|
|
def test_signer_verified_follows_the_request_identity():
|
|
token = deps._principal.set(deps.Principal(username="root", role="admin", verified=True, mode="local"))
|
|
try:
|
|
assert deps.signer_verified() is True
|
|
finally:
|
|
deps._principal.reset(token)
|
|
token = deps._principal.set(deps.Principal(username="张三", role="admin", verified=False, mode="off"))
|
|
try:
|
|
assert deps.signer_verified() is False, "关登录时署名是自报的"
|
|
finally:
|
|
deps._principal.reset(token)
|
|
assert deps.signer_verified() is False, "不在请求里(启动整理、调度循环)不算认证"
|
|
|
|
|
|
def test_the_records_write_what_they_are_given():
|
|
from app.data import source_versions
|
|
|
|
assert source_versions._revoked_record("理由", "root", True)["signed_by_verified"] is True
|
|
assert source_versions._revoked_record("理由", "root")["signed_by_verified"] is False
|
|
assert source_versions._revoked_record("理由", None, True)["signed_by_verified"] is False, "没有署名谈不上认证"
|
|
|
|
|
|
async def test_login_on_import_manifest_and_purge_record_say_verified(admin):
|
|
out = (await first_import(admin, unique("signer")))["commit"]
|
|
imp = await get(TableImport, out["import_id"])
|
|
manifest = artifact_store.load(imp.manifest_artifact)
|
|
assert manifest["signed_by"] == {"name": "root", "verified": True}
|
|
assert imp.signed_by == "root"
|
|
|
|
source_id = out["source"]["id"]
|
|
resp = await admin.post(f"/api/datasources/{source_id}/imports/{imp.id}/purge-raw",
|
|
json={"reason": "含有不应保留的内容", "signed_by": "随手填的名字"})
|
|
assert resp.status_code == 200, resp.text
|
|
purged = resp.json()["import"]["purged"]
|
|
assert (purged["signed_by"], purged["signed_by_verified"]) == ("root", True)
|